[PLAY-317] - Visual Guidelines Improvements #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidaqg
added
milano
jasperfurniss
approved these changes
Sep 9, 2022
jasperfurniss
added
the
Ready for Release
jasperfurniss
deleted the
PLAY-317-visual-guidelines-improvements-spacing
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Spacing Props:
Spacing Tokens on smaller screens:
LineHeight Tokens on smaller screens:
Positioning Tokens on smaller screens:
Breaking Changes
No breaking changes, edits to visual guidelines react styling
Runway Ticket URL
Screenshots of what screens looked like before changes can be seen on linked runway ticket:
Runway Ticket
How to test this
Review in milano env at /visual_guidelines_react
Changes to Spacing, Positioning and Line Height examples
Make sure to review react version of visual guidelines (as specified in url above). No changes to rails version of guidelines
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.