[Play-301]- Timestamp Kit Last Updated Text as Optional Prop #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidaqg
added
enhancement
nidaqg
requested review from
thestephenmarshall,
augustomallmann and
jasperfurniss
jasperfurniss
approved these changes
Sep 9, 2022
jasperfurniss
approved these changes
Sep 10, 2022
jasperfurniss
added
the
Ready for Release
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Breaking Changes
No breaking changes, added a new optional prop that allows users to not display 'Last Updated' text on elapsed variant. Default is set to display the text.
Runway Ticket URL
Runway Story
How to test this
Review Timestamp Kit in milano env, example titled 'Time Ago'. Last item in example should display timestamp without 'Last updated' Text prefixing it.
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.