Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-332] Bug - Text Input not full-width with addOn prop #2083

Merged
merged 1 commit into from
Sep 20, 2022
Merged

[PLAY-332] Bug - Text Input not full-width with addOn prop #2083

merged 1 commit into from
Sep 20, 2022

Conversation

augustomallmann
Copy link
Contributor

@augustomallmann augustomallmann commented Sep 19, 2022 •
edited
Loading

Screens

Screen Shot 2022-09-19 at 3 56 25 PM

Breaking Changes

No breaking changes. Fixed the bug that was causing the input to not display in full-width.

Runway Ticket URL

[PLAY-332]

How to test this

Use Text Input kit sending the addOn prop. Test in multiple forms.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@augustomallmann augustomallmann added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Sep 19, 2022
@augustomallmann augustomallmann requested a review from a team as a code owner September 19, 2022 18:58
gmfvpereira
gmfvpereira approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@gmfvpereira gmfvpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick response on this one.

@augustomallmann augustomallmann changed the title Fix text input with wrong display Bug - Text Input not full-width with addOn prop Sep 19, 2022
@augustomallmann augustomallmann changed the title Bug - Text Input not full-width with addOn prop [PLAY-332] Bug - Text Input not full-width with addOn prop Sep 19, 2022
@jasperfurniss jasperfurniss merged commit 3f470a2 into master Sep 20, 2022
@jasperfurniss jasperfurniss deleted the bug-text-input branch September 20, 2022 12:59
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Sep 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gmfvpereira gmfvpereira gmfvpereira approved these changes

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@nidaqg nidaqg nidaqg approved these changes

Assignees
No one assigned
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@augustomallmann @gmfvpereira @thestephenmarshall @jasperfurniss @nidaqg