[Play-346] Update pb_chart plugin to resize gauge kit on load #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art.js file, Created a doc example showing how a gauge can work nested in muliple other flex and card kits, added align=center to the flex component in the sizing.js example as well as height=100% to the last example in the sizing.js card so it renders the graph properly
Israel-Molestina
added
bug
jasperfurniss
approved these changes
Sep 23, 2022
@Israel-Molestina Can you update with a fresh screenshot? |
nidaqg
approved these changes
Sep 23, 2022
Israel-Molestina
added
Ready for Release
jasperfurniss
added
the
Ready for Release
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screens
Breaking Changes
Potentially any Gauge kits that are nested within a FlexItem with the fixedSize prop. If the fixedSize is less than 150px then you would need to add the prop:
height="100%"to the Gauge kit.Runway Ticket URL
Runway URL
How to test this
Check if all the Gauge Kit examples are properly sized on page load.
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.Milanolabel when you are ready for a review.