Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-203] Full-height Variant for Dialog #2092

Merged
merged 7 commits into from
Oct 12, 2022
Merged

[PLAY-203] Full-height Variant for Dialog #2092

merged 7 commits into from
Oct 12, 2022

Conversation

augustomallmann
Copy link
Contributor

Screens

Screen Shot 2022-09-27 at 2 15 41 PM

Screen Shot 2022-09-27 at 2 16 01 PM

Breaking Changes

No breaking changes, introducing two new props : fullHeight and placement.

Note that border-radius has changed to none for all dialogs.

Runway Ticket URL

[PLAY-203]

How to test this

  • Check for the acceptance criteria under on Runway

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@augustomallmann augustomallmann requested a review from a team as a code owner September 27, 2022 17:16
@augustomallmann augustomallmann added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Sep 27, 2022
@app-milano app-milano bot temporarily deployed to pr2092 September 27, 2022 17:32 Inactive
@app-milano app-milano bot temporarily deployed to pr2092 September 29, 2022 20:31 Inactive
@jasperfurniss jasperfurniss added 11.8.0 and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 10, 2022
@jasperfurniss jasperfurniss self-requested a review October 12, 2022 03:53
@jasperfurniss jasperfurniss merged commit 1c6f5f0 into master Oct 12, 2022
@jasperfurniss jasperfurniss deleted the full-height branch October 12, 2022 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@Israel-Molestina Israel-Molestina Awaiting requested review from Israel-Molestina

@nidaqg nidaqg Awaiting requested review from nidaqg

Assignees

@augustomallmann augustomallmann

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@augustomallmann @thestephenmarshall @jasperfurniss