Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-379]-Fixed Example Doc Border Issue #2108

Merged
merged 1 commit into from
Oct 11, 2022
Merged

[PLAY-379]-Fixed Example Doc Border Issue #2108

merged 1 commit into from
Oct 11, 2022

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Oct 10, 2022

Screens

Screen Shot 2022-10-10 at 12 13 52 PM

Breaking Changes

No, simple UI fix for visual guidelines page

Runway Ticket URL

Runway Story

How to test this

review in milano env

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added the milano 20 MAX - Deploy this PR to a review environment via Milano label Oct 10, 2022
@nidaqg nidaqg requested a review from a team as a code owner October 10, 2022 16:15
@nidaqg nidaqg self-assigned this Oct 10, 2022
@nidaqg nidaqg added the bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) label Oct 10, 2022
@jasperfurniss jasperfurniss added docs Ready for Release merged to master, ready for a versioned released and removed milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released labels Oct 10, 2022
@nidaqg nidaqg merged commit 254459d into master Oct 11, 2022
@nidaqg nidaqg deleted the PLAY-379-Visual-Guidelines-Doc-Fix branch October 11, 2022 20:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@augustomallmann augustomallmann Awaiting requested review from augustomallmann

@Israel-Molestina Israel-Molestina Awaiting requested review from Israel-Molestina

Assignees

@nidaqg nidaqg

Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nidaqg @jasperfurniss