Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-371] Dialog kit docs examples not containing contents #2109

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

augustomallmann
Copy link
Contributor


Screens

Screen Shot 2022-10-10 at 12 14 42 PM

Breaking Changes

No breaking changes, just add wrap and rowGap props.

Runway Ticket URL

[PLAY-371]

How to test this

Check milano building and simulate different screen resolutions. Check if the buttons are not overflowing its container.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@augustomallmann augustomallmann added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 10, 2022
@augustomallmann augustomallmann requested a review from a team as a code owner October 10, 2022 16:16
@jasperfurniss jasperfurniss added docs Ready for Release merged to master, ready for a versioned released and removed milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released labels Oct 10, 2022
@jasperfurniss jasperfurniss merged commit 38c76c3 into master Oct 12, 2022
@jasperfurniss jasperfurniss deleted the dialog-kit-docs-examples branch October 12, 2022 02:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants