Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-388]- Fixes For Broken Kit Generator #2132

Merged
merged 4 commits into from
Oct 24, 2022
Merged

[PLAY-388]- Fixes For Broken Kit Generator #2132

merged 4 commits into from
Oct 24, 2022

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Oct 13, 2022

Screens

Screen Shot 2022-10-13 at 10 30 11 AM

Screen Shot 2022-10-13 at 10 30 18 AM

Breaking Changes

No, Fixes broken kit generator. All files for new kit are now generated, restart of server required after running generator.

Runway Ticket URL

Runway Story

How to test this

[INSERT TESTING DETAILS]

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 13, 2022
@nidaqg nidaqg requested a review from jasperfurniss October 13, 2022 14:31
@nidaqg nidaqg self-assigned this Oct 13, 2022
@nidaqg nidaqg requested a review from a team as a code owner October 13, 2022 14:31
@nidaqg nidaqg changed the title [Play-388]- Fixes For Broken Kit Generator [PLAY-388]- Fixes For Broken Kit Generator Oct 13, 2022
thestephenmarshall
thestephenmarshall approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@thestephenmarshall thestephenmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY!! It worked the first time! 🙏

Screen Shot 2022-10-17 at 11 51 29 AM

@jasperfurniss jasperfurniss removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Oct 20, 2022
@jasperfurniss jasperfurniss merged commit 4422887 into master Oct 24, 2022
@jasperfurniss jasperfurniss deleted the PLAY-388-Kit-Generator-Broken branch October 24, 2022 13:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@nidaqg nidaqg

Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nidaqg @thestephenmarshall @jasperfurniss