Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-427]-Fixed Issue Where Typeahead Kit Was Returning Null Classes #2135

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Oct 13, 2022

Screens

Screen Shot 2022-10-13 at 11 49 42 AM

Breaking Changes

No, fixed issue where a null class was rendering in dom

Runway Ticket URL

Runway Story

How to test this

Review i n milano env. inspect each typeahead and make sure the null class is not rendering in DOM (see story for screenshot of issue)

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 13, 2022
@nidaqg nidaqg requested a review from jasperfurniss October 13, 2022 15:52
@nidaqg nidaqg self-assigned this Oct 13, 2022
@nidaqg nidaqg requested a review from a team as a code owner October 13, 2022 15:52
@jasperfurniss jasperfurniss merged commit 1464262 into master Oct 14, 2022
@jasperfurniss jasperfurniss deleted the PLAY-427-Typeahead-Kit-Null-Classes branch October 14, 2022 16:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants