Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-425] Filter kit doc cleanup #2138

Merged
merged 6 commits into from
Oct 25, 2022
Merged

[PLAY-425] Filter kit doc cleanup #2138

merged 6 commits into from
Oct 25, 2022

Conversation

Israel-Molestina
Copy link
Contributor

Screens

Screen Shot 2022-10-13 at 3 38 55 PM

Screen Shot 2022-10-13 at 3 39 05 PM

Breaking Changes

NO

Runway Ticket URL

Runway Ticket

How to test this

N/A

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@Israel-Molestina Israel-Molestina added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 13, 2022
@Israel-Molestina Israel-Molestina requested a review from a team as a code owner October 13, 2022 19:40
@Israel-Molestina Israel-Molestina self-assigned this Oct 13, 2022
@app-milano app-milano bot temporarily deployed to pr2138 October 13, 2022 19:53 Inactive
@Israel-Molestina Israel-Molestina changed the title changed min width to 360px and made max width doc example [PLAY-425] Filter kit doc cleanup Oct 14, 2022
thestephenmarshall
thestephenmarshall approved these changes Oct 17, 2022
View reviewed changes
Copy link
Contributor

@thestephenmarshall thestephenmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, great, great, I mean really, really, really, really great job! 🚀

@app-milano app-milano bot temporarily deployed to pr2138 October 17, 2022 15:24 Inactive
@Israel-Molestina Israel-Molestina added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 18, 2022
@app-milano app-milano bot temporarily deployed to pr2138 October 18, 2022 16:00 Inactive
@jasperfurniss jasperfurniss added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Oct 20, 2022
@Israel-Molestina Israel-Molestina removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Oct 21, 2022
@jasperfurniss jasperfurniss merged commit 29a0158 into master Oct 25, 2022
@jasperfurniss jasperfurniss deleted the PLAY-245-filter-kit-doc branch October 25, 2022 12:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

@jasperfurniss jasperfurniss Awaiting requested review from jasperfurniss

Assignees

@Israel-Molestina Israel-Molestina

Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Israel-Molestina @thestephenmarshall @jasperfurniss