Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-337] Converted Legend Kit to TS #2156

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Oct 25, 2022

Screens

legend-kit

Breaking Changes

No, converted Legend Kit to Typescript

Runway Ticket URL

Runway Story

How to test this

Review in milano env, make sure all examples work as expected

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano typescript labels Oct 25, 2022
@nidaqg nidaqg requested a review from jasperfurniss October 25, 2022 14:37
@nidaqg nidaqg requested a review from a team as a code owner October 25, 2022 14:37
@nidaqg nidaqg self-assigned this Oct 25, 2022
@app-milano app-milano bot temporarily deployed to pr2156 October 25, 2022 14:54 Inactive
@nidaqg nidaqg changed the title [PLAY-337]-Converted Legend Kit to TS [PLAY-337] Converted Legend Kit to TS Nov 3, 2022
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Nov 4, 2022
@nidaqg nidaqg merged commit cea4552 into master Nov 14, 2022
@nidaqg nidaqg deleted the PLAY-337-TS-Conversion-Legend branch November 14, 2022 19:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants