Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-227] Converting Enhanced Element to Typescript #2185

Merged
merged 2 commits into from
Dec 5, 2022
Merged

[PLAY-227] Converting Enhanced Element to Typescript #2185

merged 2 commits into from
Dec 5, 2022

Conversation

carloslimasd
Copy link
Contributor

Breaking Changes

No. We converted the Enhanced Element to Typescript, but we did not change any signature or behavior.

Runway Ticket URL

Runway Story

How to test this

We can test the kits that make use of the Enhanced Element. They are PbCollapsible, PbFixedConfirmationToast, PbFormValidation, PbPopover, PbTable, PbTextarea, PbTooltip, PbTypeahead.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@carloslimasd carloslimasd added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Nov 23, 2022
@carloslimasd carloslimasd requested a review from a team as a code owner November 23, 2022 15:13
@carloslimasd carloslimasd self-assigned this Nov 23, 2022
thestephenmarshall
thestephenmarshall approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@thestephenmarshall thestephenmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Dec 5, 2022
@nidaqg nidaqg merged commit 22bd962 into master Dec 5, 2022
@nidaqg nidaqg deleted the PLAY-227-enhanced-element-ts branch December 5, 2022 20:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

Assignees

@carloslimasd carloslimasd

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carloslimasd @thestephenmarshall @jasperfurniss @nidaqg