Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-236] Rebuild Charts to Use React-Highcharts #2191

Merged
merged 19 commits into from
Jan 3, 2023
Merged

[PLAY-236] Rebuild Charts to Use React-Highcharts #2191

merged 19 commits into from
Jan 3, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Nov 30, 2022

This PR removes the custom pbChart plugin that was being used for the Highcharts based kits and instead rebuilds those kits to use React-Highcharts wrapper. Kits effected:

  • Bar Graph
  • Line Graph
  • Circle Chart
  • Treemap Chart
  • Gauge Chart

The above kits have also been converted to .tsx

Screens

Screenshot 2022-11-30 at 8 48 32 AM

Screenshot 2022-11-30 at 9 02 22 AM

Screenshot 2022-11-30 at 9 02 38 AM

Screenshot 2022-11-30 at 9 02 55 AM

Screenshot 2022-11-30 at 9 03 09 AM

Breaking Changes

Yes, removes pbChart plugin and refactors charts

Runway Ticket URL

Runway Story

How to test this

To test this story:

  • Check each of the above mentioned charts to make sure all props work as expected.
  • Check react as well as rails versions of the kits
  • Compare charts in the milano env to prod to make sure nothing has changed visually

@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Nov 30, 2022
@nidaqg nidaqg requested a review from jasperfurniss November 30, 2022 14:13
@nidaqg nidaqg requested a review from a team as a code owner November 30, 2022 14:13
@nidaqg nidaqg self-assigned this Nov 30, 2022
@app-milano app-milano bot temporarily deployed to pr2191 November 30, 2022 15:16 Inactive
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Jan 3, 2023
@nidaqg nidaqg merged commit ac42014 into master Jan 3, 2023
@nidaqg nidaqg deleted the PLAY-236-refactor-pbchart-plugin branch January 3, 2023 16:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@nidaqg nidaqg

Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nidaqg @jasperfurniss