Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-460] Website: kit pages in React #2192

Merged
merged 3 commits into from
Dec 5, 2022

Conversation

Israel-Molestina
Copy link
Contributor

@Israel-Molestina Israel-Molestina commented Nov 30, 2022

Screens

Screen Shot 2022-12-01 at 10 01 13 AM

Breaking Changes

NO

Runway Ticket URL

Runway Ticket

How to test this

In the url type in /kits/:name/react/new OR /kits/:name/rails/new and check to see that the correct kit name is being rendered as a title

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@Israel-Molestina Israel-Molestina added the improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) label Nov 30, 2022
@Israel-Molestina Israel-Molestina self-assigned this Nov 30, 2022
@Israel-Molestina Israel-Molestina requested a review from a team as a code owner November 30, 2022 22:00
@Israel-Molestina Israel-Molestina added the milano 20 MAX - Deploy this PR to a review environment via Milano label Dec 1, 2022
@app-milano app-milano bot temporarily deployed to pr2192 December 1, 2022 15:12 Inactive
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Dec 5, 2022
@nidaqg nidaqg merged commit f526fe8 into master Dec 5, 2022
@nidaqg nidaqg deleted the PLAY-460-website-kit-pages-react branch December 5, 2022 21:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants