Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-525] Convert List Kit to Typescript #2234

Merged
merged 1 commit into from
Jan 16, 2023
Merged

[PLAY-525] Convert List Kit to Typescript #2234

merged 1 commit into from
Jan 16, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Dec 27, 2022 •
edited by jasperfurniss
Loading

Screens

List TS

Breaking Changes

No Breaking changes. PR converts .jsx to .tsx in List kit

Runway Ticket URL

Runway Story

How to test this

Test in milano env

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Dec 27, 2022
@nidaqg nidaqg requested a review from a team as a code owner December 27, 2022 15:47
@nidaqg nidaqg self-assigned this Dec 27, 2022
@jasperfurniss jasperfurniss added the 11.19.0 Planning to go on the 11.19.0 release. label Jan 13, 2023
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Jan 16, 2023
@jasperfurniss
Copy link
Contributor

Looks good Nida!

@nidaqg nidaqg merged commit 5d6007f into master Jan 16, 2023
@nidaqg nidaqg deleted the PLAY-525-TS-conversion-List branch January 16, 2023 16:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@nidaqg nidaqg

Labels
11.19.0 Planning to go on the 11.19.0 release. enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nidaqg @jasperfurniss