Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-520] Popover Kit Updates for Dropdown Doc Example #2235

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Dec 27, 2022

Screens

With dropdown closed:
Screenshot 2022-12-27 at 2 07 55 PM

With dropdown open:
Screenshot 2022-12-27 at 2 08 10 PM

Breaking Changes

No Breaking changes, updates to DOCs only

Runway Ticket URL

Runway Story

How to test this

Test in review env to make sure icon on dropdown example changes when clicked

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Dec 27, 2022
@nidaqg nidaqg self-assigned this Dec 27, 2022
@nidaqg nidaqg requested a review from a team as a code owner December 27, 2022 19:15
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Jan 10, 2023
@nidaqg nidaqg merged commit f6089fc into master Jan 10, 2023
@nidaqg nidaqg deleted the PLAY-520-Popover-kit-docs-only branch January 10, 2023 15:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants