Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Initial Sandpack for Feedback #2299

Merged
merged 32 commits into from
Feb 24, 2023
Merged

Initial Sandpack for Feedback #2299

merged 32 commits into from
Feb 24, 2023

Conversation

jasperfurniss
Copy link
Contributor

@jasperfurniss jasperfurniss commented Feb 6, 2023 •
edited
Loading

  • Updated the CSP to work with Sandpack
  • Got FontAwesome support working correctly for pro inside of Sandpack
  • Still missing custom font support

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

carloslimasd and others added 21 commits December 16, 2022 14:40
@carloslimasd
Implementing a Sandpack Example
dd3dd78
@carloslimasd
Adding yarn lock changes
5208f60
@carloslimasd
Resolving conflits
8f3a23e
@carloslimasd
Changing Sandpack layout
e8f9d5f
@jasperfurniss
Added Sandpack for React Examples
a6c27a5
@carloslimasd
WIP Fixing some bugs
5150819
@carloslimasd
Merging master
a7ea7e9
@carloslimasd
Reseting TableSm JSX file to master code
fc6be74
@carloslimasd
Removing JS in string to test Milano security error
07b3953
@carloslimasd
Testing CSP Rails config
c47af55
@carloslimasd
Merging master
b48a280
@carloslimasd
Using new route to render Sandpack
b15c06c
@carloslimasd
Cleaning comments on the CSP file
150f3b9
@carloslimasd
Adding header and footer descriptions
6cb5081
@carloslimasd
Merge branch 'master' into PLAY-481-sandpack-example
fb246c8
@carloslimasd
Removing unnecessary code
3b114f5
@carloslimasd
Merge remote-tracking branch 'origin/PLAY-481-sandpack-example' into …
f77baed 
…PLAY-481-sandpack-example
@carloslimasd
Merging master
93bcd5d
@carloslimasd
Adding new route demo to show different examples
9a6b5c4
@carloslimasd
Merge remote-tracking branch 'origin/master' into PLAY-481-sandpack-e…
adb8898 
…xample
@carloslimasd
Changing the way that we are importing Playbook CSS
49f1340
@jasperfurniss jasperfurniss requested a review from a team as a code owner February 6, 2023 16:06
@jasperfurniss jasperfurniss self-assigned this Feb 6, 2023
@jasperfurniss jasperfurniss added the milano 20 MAX - Deploy this PR to a review environment via Milano label Feb 6, 2023
@app-milano app-milano bot temporarily deployed to pr2299 February 6, 2023 19:45 Inactive
@app-milano app-milano bot temporarily deployed to pr2299 February 8, 2023 15:07 Inactive
@carloslimasd carloslimasd force-pushed the PLAY-481-sandpack-example branch from 4ebc20e to 308a78d Compare February 9, 2023 16:56
@app-milano app-milano bot temporarily deployed to pr2299 February 9, 2023 17:13 Inactive
@jasperfurniss jasperfurniss changed the title Testing Sandpack with Safe Content Security Policy Initial Sandpack for Feedback Feb 15, 2023
@app-milano app-milano bot temporarily deployed to pr2299 February 15, 2023 20:22 Inactive
nidaqg
nidaqg approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@nidaqg nidaqg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Jasper!

@app-milano app-milano bot temporarily deployed to pr2299 February 22, 2023 15:03 Inactive
@app-milano app-milano bot temporarily deployed to pr2299 February 22, 2023 17:37 Inactive
@app-milano app-milano bot temporarily deployed to pr2299 February 22, 2023 21:43 Inactive
@jasperfurniss jasperfurniss added this pull request to the merge queue Feb 24, 2023
Merged via the queue into master with commit d489922 Feb 24, 2023
@jasperfurniss jasperfurniss deleted the PLAY-481-sandpack-example branch February 24, 2023 14:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nidaqg nidaqg nidaqg approved these changes

Assignees

@jasperfurniss jasperfurniss

Labels
milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasperfurniss @nidaqg @carloslimasd