Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-602] Selectable Cards hover target area update #2345

Merged
merged 5 commits into from
Mar 8, 2023

Conversation

Israel-Molestina
Copy link
Contributor

Screens

Screen Shot 2023-03-03 at 4 09 23 PM

Breaking Changes

NO

Runway Ticket URL

Runway Ticket

How to test this

Check that selectable card icon kits hover appropriatly

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY Please add the Milano label when you are ready for a review.
  • SCREENSHOT Please add a screen shot or two.
  • SPECS Please cover your changes with specs.
  • READ DOCS Please make sure you have read and understand the Playbook Release Process

@Israel-Molestina Israel-Molestina added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Mar 3, 2023
@Israel-Molestina Israel-Molestina self-assigned this Mar 3, 2023
@Israel-Molestina Israel-Molestina requested a review from a team as a code owner March 3, 2023 21:10
@app-milano app-milano bot temporarily deployed to pr2345 March 3, 2023 21:24 Inactive
@@ -5,6 +5,7 @@
text-align: center;
cursor: pointer;
transition: all $transition_short ease;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your linter/formatter is doing some wonky indentation. I don't mind the blank lines here if they are intentional for making some space/breathing room, ....but i would want you to investigate later getting prettier configured locally or something.

@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Mar 7, 2023
@nidaqg nidaqg merged commit 3cb2c6d into master Mar 8, 2023
@nidaqg nidaqg deleted the PLAY-602-bug-selectable-card-hover-area branch March 8, 2023 14:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants