[PLAY-713] Convert kit to typescript #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdoeswork
commented
Apr 12, 2023
markdoeswork
commented
Apr 12, 2023
markdoeswork
added
enhancement
nidaqg
reviewed
Apr 12, 2023
nidaqg
reviewed
Apr 12, 2023
jasperfurniss
approved these changes
Apr 18, 2023
jasperfurniss
added
the
Ready for Release
jasperfurniss
added a commit
that referenced
this pull request
Apr 24, 2023
**What does this PR do?** A clear and concise description with your runway ticket url. Converts the `textarea.jsx` to typescript `textarea.tsx` and adds a test **Screenshots:** Screenshots to visualize your addition/change There are no visual changes **How to test?** Steps to confirm the desired behavior: 1. Go to http://127.0.0.1:3000/kits/textarea/react# 2. Test all of the examples on the page #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [x] **TESTS** I have added test coverage to my code. --------- Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com>
jasperfurniss
added a commit
that referenced
this pull request
Apr 26, 2023
**What does this PR do?** A clear and concise description with your runway ticket url. Converts the `textarea.jsx` to typescript `textarea.tsx` and adds a test **Screenshots:** Screenshots to visualize your addition/change There are no visual changes **How to test?** Steps to confirm the desired behavior: 1. Go to http://127.0.0.1:3000/kits/textarea/react# 2. Test all of the examples on the page #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [x] **TESTS** I have added test coverage to my code. --------- Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Converts the
textarea.jsxto typescripttextarea.tsxand adds a testScreenshots: Screenshots to visualize your addition/change
There are no visual changes
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.