Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-673] Loop through all kits #2464

Merged
merged 13 commits into from
May 3, 2023
Merged

[PLAY-673] Loop through all kits #2464

merged 13 commits into from
May 3, 2023

Conversation

markdoeswork
Copy link
Contributor

@markdoeswork markdoeswork commented Apr 14, 2023

What does this PR do? A clear and concise description with your runway ticket url.
https://nitro.powerhrg.com/runway/backlog_items/PLAY-673

Adds a test to make sure ClassName is the last class for each component

Originally tried to use front end testing to load each component and view the classname, but some components have required props to load

Then tried to load the Modules/Functions and read the const classes but because they are private variables they are not always exposed.

Ended up using ruby and a regular expression to just read the file and make sure that Classname was where it should be

Screenshots: Screenshots to visualize your addition/change
screenshot-nimbusweb me-2023 04 26-10_13_39

How to test? Steps to confirm the desired behavior:

  1. Go to playbook/spec/pb_kits/playbook/all_kits_spec.rb
  2. Run the test

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@markdoeswork markdoeswork self-assigned this Apr 14, 2023
@markdoeswork markdoeswork added the milano 20 MAX - Deploy this PR to a review environment via Milano label Apr 26, 2023
@app-milano app-milano bot temporarily deployed to pr2464 April 26, 2023 20:11 Inactive
@app-milano app-milano bot temporarily deployed to pr2464 April 26, 2023 21:18 Inactive
@markdoeswork markdoeswork marked this pull request as ready for review April 27, 2023 13:05
@markdoeswork markdoeswork requested a review from a team as a code owner April 27, 2023 13:05
@app-milano app-milano bot temporarily deployed to pr2464 April 27, 2023 14:47 Inactive
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Apr 28, 2023
@nidaqg nidaqg added this pull request to the merge queue May 3, 2023
Merged via the queue into master with commit 083a2f4 May 3, 2023
@nidaqg nidaqg deleted the play/673_test_for_classname branch May 3, 2023 18:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants