Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Markdown repairs & re-enable smart markdown docs in Playbook #2465

Merged
merged 7 commits into from
May 3, 2023

Conversation

jasoncypret
Copy link
Member

@jasoncypret jasoncypret commented Apr 14, 2023

What does this PR do? A clear and concise description with your runway ticket url.

  • ✅ enables .md extension in rails
  • ✅ enables renderof markdown as partials
  • ✅ Custom HTML blocks for Tables, & Headings
  • ✅ Updated markdown styling based on new editor
  • ✅ Adds dynamically rendered markdown as a template through routes
  • ✅ Adds dynamically generated markdown title
  • ✅ Adds dynamically generated "edit this" button
  • ✅ Removed SLIM dependency
  • ✅ Dynamically generated docs navigation based on docs folder structure
  • ✅ Upgrades Redcarpet 3.5 -> 3.6

Screenshots: Screenshots to visualize your addition/change

Screenshot 2023-04-14 at 5 40 29 PM

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@jasoncypret jasoncypret requested a review from a team as a code owner April 14, 2023 22:45
@jasoncypret jasoncypret changed the title Markdown repairs to re-enable smart markdown docs in Playbook Markdown repairs & re-enable smart markdown docs in Playbook Apr 16, 2023
@nidaqg nidaqg added the milano 20 MAX - Deploy this PR to a review environment via Milano label Apr 17, 2023
@app-milano app-milano bot temporarily deployed to pr2465 April 17, 2023 20:16 Inactive
@nidaqg nidaqg added Ready for Release merged to master, ready for a versioned released wip and removed Ready for Release merged to master, ready for a versioned released labels Apr 18, 2023
@jasoncypret jasoncypret removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Apr 28, 2023
@jasoncypret jasoncypret added the milano 20 MAX - Deploy this PR to a review environment via Milano label May 1, 2023
@jasperfurniss jasperfurniss added this pull request to the merge queue May 3, 2023
Merged via the queue into master with commit 0d42023 May 3, 2023
@jasperfurniss jasperfurniss deleted the markdown/repairs branch May 3, 2023 14:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants