Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-788] Fix React Global Props Table #2513

Merged
merged 3 commits into from
May 3, 2023
Merged

[PLAY-788] Fix React Global Props Table #2513

merged 3 commits into from
May 3, 2023

Conversation

markdoeswork
Copy link
Contributor

@markdoeswork markdoeswork commented Apr 28, 2023 •
edited
Loading

What does this PR do? A clear and concise description with your runway ticket url.

This PR is a clone of #2474. It had to be reverted due to a large number of issues. This PR had a tricky merge conflict to resolve so this PR is the entirety of the original PR and the merge conflict resolution

Screenshots: Screenshots to visualize your addition/change

screenshot-127 0 0 1_3000-2023 05 01-16_07_29

How to test? Steps to confirm the desired behavior:

  1. Go to a kit on playbook-website
  2. Click on any kit (make sure react)
  3. Scroll down to the bottom of the page
  4. See the props table

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • [😈] TESTS I have added test coverage to my code.

@markdoeswork markdoeswork self-assigned this Apr 28, 2023
@markdoeswork markdoeswork added the milano 20 MAX - Deploy this PR to a review environment via Milano label May 1, 2023
@app-milano app-milano bot temporarily deployed to pr2513 May 1, 2023 19:58 Inactive
@markdoeswork markdoeswork marked this pull request as ready for review May 2, 2023 13:15
@markdoeswork markdoeswork requested a review from a team as a code owner May 2, 2023 13:15
@nidaqg nidaqg changed the title [PLAY-788] Cherry pick the original PR [PLAY-788] Fix React Global Props Table May 3, 2023
@nidaqg nidaqg added improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) Ready for Release merged to master, ready for a versioned released labels May 3, 2023
@nidaqg nidaqg added this pull request to the merge queue May 3, 2023
Merged via the queue into master with commit b27ed7f May 3, 2023
@nidaqg nidaqg deleted the play/788_fix_react_global_props branch May 3, 2023 18:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nidaqg nidaqg nidaqg approved these changes

Assignees

@markdoeswork markdoeswork

Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markdoeswork @nidaqg