Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Title 2 Defaults to Bold #2559

Merged
merged 2 commits into from
May 25, 2023
Merged

Title 2 Defaults to Bold #2559

merged 2 commits into from
May 25, 2023

Conversation

jasperfurniss
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.
This sets Title 2 to default to Bold now.
This can still be turned off manually on an individual kit basis, as an escape hatch if need be.

Screenshots: Screenshots to visualize your addition/change
Updated the copy as well to reflect the changes.
Screenshot 2023-05-15 at 1 43 41 PM
Screenshot 2023-05-15 at 1 43 53 PM

How to test? Steps to confirm the desired behavior:

  1. Go to any title size=2 and see bold for rails/react.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
    - [] TESTS I have added test coverage to my code.

@jasperfurniss jasperfurniss self-assigned this May 15, 2023
@jasperfurniss jasperfurniss requested a review from a team as a code owner May 15, 2023 17:49
@jasperfurniss jasperfurniss added milano 20 MAX - Deploy this PR to a review environment via Milano alpha labels May 15, 2023
@github-actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 12.20.0.pre.alpha.title2665

Your Alpha for NPM is 12.20.0-alpha.title2665

@jasperfurniss jasperfurniss added enhancement New Features, Props, & Variants (USED IN CHANGELOG) alpha and removed alpha labels May 15, 2023
@app-milano app-milano bot temporarily deployed to pr2559 May 15, 2023 18:08 Inactive
@github-actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 12.20.0.pre.alpha.title2667

Your Alpha for NPM is 12.20.0-alpha.title2667

@jasperfurniss jasperfurniss added release 2 Ready for Release merged to master, ready for a versioned released labels May 23, 2023
@jasperfurniss jasperfurniss added this pull request to the merge queue May 25, 2023
Merged via the queue into master with commit 2a846a1 May 25, 2023
@jasperfurniss jasperfurniss deleted the title2 branch May 25, 2023 18:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released release 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants