[PLAY-698] responsive Spacing global prop #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…powerhome/playbook into play-698-responsive-spacing-global-prop
This reverts commit 83364c2.
jasperfurniss
added
the
milano
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 12.22.0.pre.alpha.play698responsivespacingglobalprop690 Your Alpha for NPM is 12.22.0-alpha.play698responsivespacingglobalprop690 |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 12.23.0.pre.alpha.play698responsivespacingglobalprop701 Your Alpha for NPM is 12.23.0-alpha.play698responsivespacingglobalprop701 |
nickamantia
added
the
improvement
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 12.23.0.pre.alpha.play698responsivespacingglobalprop703 Your Alpha for NPM is 12.23.0-alpha.play698responsivespacingglobalprop703 |
jasperfurniss
added
the
Ready for Release
…powerhome/playbook into play-698-responsive-spacing-global-prop
jasperfurniss
approved these changes
May 25, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
PLAY-698
This PR:
auto,initial, andinheritSpacingglobal props so they are responsiveScreenshots
: Screenshots to visualize your addition/change
Rails:
Screen.Recording.2023-05-23.at.02.38.59.PM.mp4
React:
Screen.Recording.2023-05-23.at.02.44.31.PM.mp4
Updated Global Props table with
auto,initial, andinheritHow to test? Steps to confirm the desired behavior:
React Example:
padding={{ xs: "xxs", sm: "xs", md: "xl", lg: "md", xl: "none" }}Rails Example:
padding: { xs: "xxs", sm: "xs", md: "xl", lg: "md", xl: "none" }Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.