Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-834] Fixes for darkmode Styling of TextInput #2575

Merged
merged 2 commits into from
May 23, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented May 22, 2023

What does this PR do? A clear and concise description with your runway ticket url.

This PR fixes broken dark mode styling for TextInput with icon add on.

PLAY-834

Screenshots: Screenshots to visualize your addition/change

Screenshot 2023-05-21 at 10 44 23 AM

How to test? Steps to confirm the desired behavior:

  1. Go to TextInput in dark mode and scroll to 'Add on' doc example

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nidaqg nidaqg added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels May 22, 2023
@nidaqg nidaqg requested a review from a team as a code owner May 22, 2023 12:38
@nidaqg nidaqg self-assigned this May 22, 2023
@app-milano app-milano bot temporarily deployed to pr2575 May 22, 2023 12:54 Inactive
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label May 22, 2023
@nidaqg nidaqg added this pull request to the merge queue May 23, 2023
Merged via the queue into master with commit 742f495 May 23, 2023
@nidaqg nidaqg deleted the testing-text-input-dark branch May 23, 2023 16:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants