Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-843] Kit mashup page for handoffs #2583

Merged
merged 28 commits into from
Jun 15, 2023
Merged

[PLAY-843] Kit mashup page for handoffs #2583

merged 28 commits into from
Jun 15, 2023

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Jun 2, 2023 •
edited
Loading

This PR adds the ability for users to search for multiple kits and once and render them all on the same page.
Example: /kit_collection/title&card&avatar/card/react

PLAY-843

Screen Shot 2023-06-13 at 1 19 07 PM

How to test? Steps to confirm the desired behavior:

  1. Go to the kits route and type in multiple kits WITH a &separated between each kit. Example: /kit_collection/title&card&avatar/card/react
  2. see if multiple kits render on screen

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia self-assigned this Jun 2, 2023
@jasperfurniss jasperfurniss added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jun 6, 2023
@jasperfurniss jasperfurniss added the improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) label Jun 6, 2023
@app-milano app-milano bot temporarily deployed to pr2583 June 6, 2023 13:25 Inactive
@app-milano app-milano bot temporarily deployed to pr2583 June 7, 2023 18:39 Inactive
@nickamantia nickamantia marked this pull request as ready for review June 7, 2023 19:42
@nickamantia nickamantia requested a review from a team as a code owner June 7, 2023 19:42
nidaqg
nidaqg previously approved these changes Jun 8, 2023
View reviewed changes
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Jun 8, 2023
@jasperfurniss jasperfurniss removed Ready for Release merged to master, ready for a versioned released release 2 labels Jun 8, 2023
@app-milano app-milano bot temporarily deployed to pr2583 June 8, 2023 20:57 Inactive
@app-milano app-milano bot temporarily deployed to pr2583 June 12, 2023 16:33 Inactive
@app-milano app-milano bot temporarily deployed to pr2583 June 12, 2023 18:11 Inactive
@app-milano app-milano bot temporarily deployed to pr2583 June 13, 2023 17:14 Inactive
@app-milano app-milano bot temporarily deployed to pr2583 June 13, 2023 17:37 Inactive
@app-milano app-milano bot temporarily deployed to pr2583 June 13, 2023 19:53 Inactive
@app-milano app-milano bot temporarily deployed to pr2583 June 14, 2023 20:09 Inactive
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Jun 15, 2023
@nidaqg nidaqg added this pull request to the merge queue Jun 15, 2023
Merged via the queue into master with commit be19e91 Jun 15, 2023
@nidaqg nidaqg deleted the play-843-kit-mashup-page branch June 15, 2023 18:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@nidaqg nidaqg nidaqg approved these changes

Assignees

@nickamantia nickamantia

Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickamantia @jasperfurniss @nidaqg