Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-865] Font weight tokens updates #2609

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Jun 20, 2023

PLAY-865

This PR updates any font-weight that doesn't use one of our tokens

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to any of the kits that got updated
    -Date Picker
    -Form Pill
    -Rich Test Editor

  2. Check to see if it still has the correct font-weight

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia self-assigned this Jun 21, 2023
@nickamantia nickamantia added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jun 21, 2023
@app-milano app-milano bot temporarily deployed to pr2609 June 21, 2023 15:04 Inactive
@nickamantia nickamantia added the improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) label Jun 21, 2023
@nickamantia nickamantia marked this pull request as ready for review June 21, 2023 15:46
@nickamantia nickamantia requested a review from a team as a code owner June 21, 2023 15:46
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Jun 26, 2023
@nidaqg nidaqg added this pull request to the merge queue Jun 27, 2023
Merged via the queue into master with commit 4318758 Jun 27, 2023
@nidaqg nidaqg deleted the play-865-font-weight-tokens-updates branch June 27, 2023 20:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants