Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-878] Add CSS for Changelog Dates #2616

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Conversation

gavhuang
Copy link
Contributor

@gavhuang gavhuang commented Jun 23, 2023

What does this PR do?

  • Runway
  • In the changelog's markdown file, use h5 for the date below the title (see screenshots)
    • CSS is the same as the Caption kit
  • Add changelog dates to 12.24 and 12.25 and update the Example Markdown Styling page with the h5 description
  • Redcarpet adds a copy link on hover to all headers, but this is a quick ship story

Screenshots:

Add Changelog Dates

Screenshot 2023-06-25 at 8 48 27 PM Screenshot 2023-06-25 at 8 48 01 PM

Add h5 Description to Example Markdown Styling Page

Screenshot 2023-06-25 at 8 52 40 PM

How to test? Steps to confirm the desired behavior:

  1. Go to /changelog
  • In the changelog file, add a h5 right below the h1 title.
  1. Go to /guides/design_guidelines/example_markdown_styling
  • View the added h5 description for changelog dates

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@gavhuang gavhuang added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Jun 23, 2023
@gavhuang gavhuang requested a review from a team as a code owner June 23, 2023 03:27
@gavhuang gavhuang self-assigned this Jun 23, 2023
@gavhuang gavhuang added improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) and removed enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Jun 23, 2023
@app-milano app-milano bot temporarily deployed to pr2616 June 23, 2023 03:50 Inactive
@app-milano app-milano bot temporarily deployed to pr2616 June 26, 2023 01:06 Inactive
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Jun 26, 2023
@nidaqg nidaqg added this pull request to the merge queue Jun 26, 2023
Merged via the queue into master with commit 3973c77 Jun 26, 2023
@nidaqg nidaqg deleted the PLAY-878-DateStamp-Changelog branch June 26, 2023 19:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants