Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-889] Fixed Expanded State to Load From TreeData #2621

Merged
merged 2 commits into from
Jun 29, 2023

Conversation

jasperfurniss
Copy link
Contributor

@jasperfurniss jasperfurniss commented Jun 28, 2023

What does this PR do? A clear and concise description with your runway ticket url.
Fixes the expanded, so that the database can recall your expanded selections upon page reload.

video.mp4

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to MultiLevel and see the data coming from the tree structure for expanded states.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
    - [X] TESTS I have added test coverage to my code.

@jasperfurniss jasperfurniss requested a review from a team as a code owner June 28, 2023 19:47
@jasperfurniss jasperfurniss self-assigned this Jun 28, 2023
@jasperfurniss jasperfurniss added enhancement New Features, Props, & Variants (USED IN CHANGELOG) bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano alpha and removed enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Jun 28, 2023
@github-actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 12.27.0.pre.alpha.expandednotworking853

Your Alpha for NPM is 12.27.0-alpha.expandednotworking853

@app-milano app-milano bot temporarily deployed to pr2621 June 28, 2023 20:04 Inactive
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Jun 29, 2023
@app-milano app-milano bot deployed to pr2621 June 29, 2023 12:41 Active
@jasperfurniss jasperfurniss changed the title Fixed Expanded State to Load From TreeData [PLAY-889] Fixed Expanded State to Load From TreeData Jun 29, 2023
@jasperfurniss jasperfurniss added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jun 29, 2023
@app-milano app-milano bot temporarily deployed to pr2621 June 29, 2023 16:09 Inactive
@nidaqg nidaqg added this pull request to the merge queue Jun 29, 2023
Merged via the queue into master with commit caeb78d Jun 29, 2023
@nidaqg nidaqg deleted the expanded-not-working branch June 29, 2023 19:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants