Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-903] Circle Icon with Emojis #2633

Merged
merged 13 commits into from
Jul 11, 2023
Merged

[PLAY-903] Circle Icon with Emojis #2633

merged 13 commits into from
Jul 11, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Jul 7, 2023

What does this PR do? A clear and concise description with your runway ticket url.

  • Creates new 'emoji' prop for IconCircle kit so it can accept HTML emojis
  • Allows kit to take emojis + unicode for emojis
  • validates that text passed in is an emoji before rendering to page
  • Only render icon OR emoji so both are not rendered if user tries to pass in both props
  • Works for react and rails

Screenshots: Screenshots to visualize your addition/change

Screenshot 2023-07-07 at 2 44 25 PM

@nidaqg nidaqg added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Jul 7, 2023
@nidaqg nidaqg self-assigned this Jul 7, 2023
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-903-circle-icon-with-emoji

@app-milano app-milano bot temporarily deployed to pr2633 July 7, 2023 20:52 Inactive
@app-milano app-milano bot temporarily deployed to pr2633 July 9, 2023 02:00 Inactive
@nidaqg nidaqg marked this pull request as ready for review July 9, 2023 03:54
@nidaqg nidaqg requested a review from a team as a code owner July 9, 2023 03:54
@nidaqg nidaqg changed the title [PLAY 903] Circle Icon with Emojis [PLAY-903] Circle Icon with Emojis Jul 9, 2023
@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Jul 9, 2023
@nidaqg nidaqg removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Jul 10, 2023
@nidaqg nidaqg added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jul 10, 2023
@app-milano app-milano bot temporarily deployed to pr2633 July 10, 2023 18:00 Inactive
@app-milano app-milano bot temporarily deployed to pr2633 July 10, 2023 20:40 Inactive
@app-milano app-milano bot temporarily deployed to pr2633 July 11, 2023 11:43 Inactive
jasperfurniss
jasperfurniss previously approved these changes Jul 11, 2023
View reviewed changes
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Jul 11, 2023
@nidaqg nidaqg added this pull request to the merge queue Jul 11, 2023
Merged via the queue into master with commit b596ccb Jul 11, 2023
@nidaqg nidaqg deleted the PLAY-903-circle-icon-with-emoji branch July 11, 2023 17:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@nidaqg nidaqg

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nidaqg @jasperfurniss