Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Setting the global props
flexGrow
andflexShrink
to0
doesn't workbecause they are emitted using a truthiness check, which
0
fails.This results in
flexGrow={0}
returning an empty string and not addingthe
flex_grow_0
class and consequently not applying the `flex-grow: 0;'style to the component.
This commit fixes the bug by replacing the truthiness check with an inclusion
check using the
Binary
type of theflexGrow
andflexShrink
props.
Screenshots: Screenshots to visualize your addition/change
N/A
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.