Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-901] Adding new dashed section separator #2640

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

carloslimasd
Copy link
Contributor

@carloslimasd carloslimasd commented Jul 12, 2023

What does this PR do?
Make the kit accept children, and users are now able to use a dashed separator.

Screenshots:
image
image

How to test?

  1. Go to the Section Separator kit

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@carloslimasd carloslimasd added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Jul 12, 2023
@carloslimasd carloslimasd self-assigned this Jul 12, 2023
@carloslimasd carloslimasd requested a review from a team as a code owner July 12, 2023 15:01
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-901-dashed-separator

@app-milano app-milano bot temporarily deployed to pr2640 July 12, 2023 18:05 Inactive
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Jul 13, 2023
@app-milano app-milano bot temporarily deployed to pr2640 July 13, 2023 16:25 Inactive
@nidaqg nidaqg added this pull request to the merge queue Jul 13, 2023
Merged via the queue into master with commit 45e973c Jul 13, 2023
@nidaqg nidaqg deleted the PLAY-901-dashed-separator branch July 13, 2023 18:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants