Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refactor Dialog Kit Close on Outside Click #2650

Merged
merged 5 commits into from
Jul 21, 2023
Merged

Refactor Dialog Kit Close on Outside Click #2650

merged 5 commits into from
Jul 21, 2023

Conversation

gavhuang
Copy link
Contributor

@gavhuang gavhuang commented Jul 17, 2023 •
edited
Loading

What does this PR do?

  • Refactors the Dialog Rails kit's "click outside to close" feature to not be dependent on the data-open-dialog attribute
  • If not improved, this could block the SweetAlert replacement (see POC: PBNTR-62)

How to test?

  1. Go to the Dialog Rails kit
  2. Open a dialog, then click outside to close
  3. Go to the "Overlay Click" example. You should NOT be able to close.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@gavhuang gavhuang added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Jul 17, 2023
@gavhuang gavhuang requested a review from markdoeswork July 17, 2023 17:15
@gavhuang gavhuang self-assigned this Jul 17, 2023
@app-milano app-milano bot temporarily deployed to pr2650 July 17, 2023 17:34 Inactive
@gavhuang gavhuang marked this pull request as ready for review July 18, 2023 14:21
@gavhuang gavhuang requested a review from a team as a code owner July 18, 2023 14:21
jasperfurniss
jasperfurniss previously approved these changes Jul 18, 2023
View reviewed changes
@app-milano app-milano bot temporarily deployed to pr2650 July 18, 2023 18:40 Inactive
@nidaqg nidaqg added Ready for Release merged to master, ready for a versioned released and removed release 2 labels Jul 19, 2023
@app-milano app-milano bot temporarily deployed to pr2650 July 19, 2023 16:18 Inactive
@nidaqg nidaqg added this pull request to the merge queue Jul 21, 2023
Merged via the queue into master with commit d159ed2 Jul 21, 2023
@nidaqg nidaqg deleted the close-dialog-on-outside-click branch July 21, 2023 18:56
nidaqg added a commit that referenced this pull request Jul 22, 2023
@nidaqg
Revert "Refactor Dialog Kit Close on Outside Click (#2650)"
68344f0 
This reverts commit d159ed2.
@nidaqg nidaqg mentioned this pull request Jul 22, 2023
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@Israel-Molestina Israel-Molestina Israel-Molestina approved these changes

@nidaqg nidaqg nidaqg approved these changes

@markdoeswork markdoeswork Awaiting requested review from markdoeswork

Assignees

@gavhuang gavhuang

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gavhuang @jasperfurniss @markdoeswork @Israel-Molestina @nidaqg