-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[PLAY-910] Adding children prop to Fixed Confirmation Toast #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-910-confirmation-toast-children |
playbook/app/pb_kits/playbook/pb_fixed_confirmation_toast/_fixed_confirmation_toast.tsx
Outdated
Show resolved
Hide resolved
…ed_confirmation_toast.tsx
jasperfurniss
previously approved these changes
Jul 18, 2023
thestephenmarshall
approved these changes
Jul 18, 2023
jasperfurniss
added a commit
that referenced
this pull request
Jul 21, 2023
**What does this PR do?** Implements a children's prop to the Fixed Confirmation Toast kit, so I pass custom content (i.e., links) to my toasts. **Screenshots:**  **How to test?** 1. Go to the Fixed Confirmation Toast kit doc page 2. Scroll down to the children example #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [ ] **TESTS** I have added test coverage to my code. --------- Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
enhancement
New Features, Props, & Variants (USED IN CHANGELOG)
milano
20 MAX - Deploy this PR to a review environment via Milano
Ready for Release
merged to master, ready for a versioned released
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements a children's prop to the Fixed Confirmation Toast kit, so I pass custom content (i.e., links) to my toasts.
Screenshots:

How to test?
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.