Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-910] Adding children prop to Fixed Confirmation Toast #2651

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

carloslimasd
Copy link
Contributor

@carloslimasd carloslimasd commented Jul 18, 2023

What does this PR do?
Implements a children's prop to the Fixed Confirmation Toast kit, so I pass custom content (i.e., links) to my toasts.

Screenshots:
image

How to test?

  1. Go to the Fixed Confirmation Toast kit doc page
  2. Scroll down to the children example

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@carloslimasd carloslimasd added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Jul 18, 2023
@carloslimasd carloslimasd self-assigned this Jul 18, 2023
@carloslimasd carloslimasd requested a review from a team as a code owner July 18, 2023 14:04
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-910-confirmation-toast-children

@app-milano app-milano bot temporarily deployed to pr2651 July 18, 2023 14:25 Inactive
jasperfurniss
jasperfurniss previously approved these changes Jul 18, 2023
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Jul 18, 2023
@app-milano app-milano bot temporarily deployed to pr2651 July 18, 2023 17:30 Inactive
@jasperfurniss jasperfurniss added this pull request to the merge queue Jul 18, 2023
Merged via the queue into master with commit 9ecbbee Jul 18, 2023
@jasperfurniss jasperfurniss deleted the PLAY-910-confirmation-toast-children branch July 18, 2023 18:44
jasperfurniss added a commit that referenced this pull request Jul 21, 2023
**What does this PR do?**
Implements a children's prop to the Fixed Confirmation Toast kit, so I
pass custom content (i.e., links) to my toasts.

**Screenshots:**

![image](https://github.com/powerhome/playbook/assets/2573205/e8272c41-9012-44db-bb97-4846a0b3d53c)

**How to test?**
1. Go to the Fixed Confirmation Toast kit doc page
2. Scroll down to the children example


#### Checklist:
- [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new
kit`, `deprecated`, or `breaking`. See [Changelog &
Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels)
for details.
- [x] **DEPLOY** I have added the `milano` label to show I'm ready for a
review.
- [ ] **TESTS** I have added test coverage to my code.

---------

Co-authored-by: Jasper Furniss <jasper.furniss@powerhrg.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants