Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-912] 🌐 kit_collection: add kit + global props table to Rails page #2659

Merged
merged 2 commits into from
Jul 21, 2023
Merged

[PLAY-912] 🌐 kit_collection: add kit + global props table to Rails page #2659

merged 2 commits into from
Jul 21, 2023

Conversation

Israel-Molestina
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.
Added the Rails kit and global props table to the rails kit mash up page
Runway Ticket

Screenshots: Screenshots to visualize your addition/change
Screenshot 2023-07-20 at 2 34 27 PM

How to test? Steps to confirm the desired behavior:

  1. Go to https://playbook.powerapp.cloud/kit_collection/title&card&nav
  2. Scroll to the bottom
  3. Ensure both kit and global prop tables are functioning correctly
  4. Change between different kits and ensure that the tables show up as they should for each kit.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@Israel-Molestina Israel-Molestina added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Jul 20, 2023
@Israel-Molestina Israel-Molestina self-assigned this Jul 20, 2023
@Israel-Molestina Israel-Molestina requested a review from a team as a code owner July 20, 2023 18:34
carloslimasd
carloslimasd previously approved these changes Jul 20, 2023
View reviewed changes
@app-milano app-milano bot temporarily deployed to pr2659 July 20, 2023 18:52 Inactive
nidaqg
nidaqg previously approved these changes Jul 20, 2023
View reviewed changes
@nidaqg nidaqg added Ready for Release merged to master, ready for a versioned released and removed Ready for Release merged to master, ready for a versioned released labels Jul 20, 2023
@Israel-Molestina Israel-Molestina dismissed stale reviews from nidaqg and carloslimasd via 51930b8 July 20, 2023 20:46
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Jul 21, 2023
@nidaqg nidaqg added this pull request to the merge queue Jul 21, 2023
Merged via the queue into master with commit 25bc4d5 Jul 21, 2023
@nidaqg nidaqg deleted the PLAY-912-add-props-table-kit-collection-page branch July 21, 2023 18:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@nidaqg nidaqg nidaqg approved these changes

@carloslimasd carloslimasd carloslimasd left review comments

Assignees

@Israel-Molestina Israel-Molestina

Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Israel-Molestina @carloslimasd @jasperfurniss @nidaqg