Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-961] Turn off Rails deprecation warnings #2739

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Sep 13, 2023

PLAY-961

This PR turns off deprecation warnings to solve issue 2676

Screenshots: Screenshots to visualize your addition/change

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia added the milano 20 MAX - Deploy this PR to a review environment via Milano label Sep 13, 2023
@nickamantia nickamantia self-assigned this Sep 13, 2023
@github-actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.4.0.pre.alpha.play961turnoffdeprecationwarnings1171

Your Alpha for NPM is 13.4.0-alpha.play961turnoffdeprecationwarnings1171

@app-milano app-milano bot temporarily deployed to pr2739 September 13, 2023 19:36 Inactive
@jasperfurniss jasperfurniss marked this pull request as ready for review September 19, 2023 13:46
@jasperfurniss jasperfurniss requested a review from a team as a code owner September 19, 2023 13:46
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Sep 19, 2023
@nidaqg nidaqg added this pull request to the merge queue Sep 19, 2023
Merged via the queue into master with commit 14354e5 Sep 19, 2023
@nidaqg nidaqg deleted the play-961-turn-off-deprecation-warnings branch September 19, 2023 17:34
@xjunior
Copy link
Contributor

xjunior commented Oct 19, 2023

Hello, @nickamantia. Shouldn't we fix the offenders first, if these are actually deprecated?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants