Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-823] Global Prop Overflow #2744

Merged
merged 9 commits into from
Sep 19, 2023
Merged

[PLAY-823] Global Prop Overflow #2744

merged 9 commits into from
Sep 19, 2023

Conversation

nidaqg
Copy link
Contributor

@nidaqg nidaqg commented Sep 15, 2023 •
edited
Loading

What does this PR do?

  • Creates the new overflow global prop
  • Caters to overflow, overflowX/overflow_x and overflowY/overflow_y
  • Created docs on visual guidelines page
  • Removed the overflow prop on flexitem since it was doing same thing our global prop does now and there was no default in the kit

@nidaqg nidaqg requested a review from a team as a code owner September 15, 2023 12:54
@nidaqg nidaqg self-assigned this Sep 15, 2023
@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Sep 15, 2023
@app-milano app-milano bot temporarily deployed to pr2744 September 15, 2023 17:17 Inactive
@github-actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.5.0.pre.alpha.PLAY823globalpropoverflow1188

Your Alpha for NPM is 13.5.0-alpha.PLAY823globalpropoverflow1188

@nidaqg nidaqg added alpha and removed alpha labels Sep 15, 2023
@github-actions
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.5.0.pre.alpha.PLAY823globalpropoverflow1191

Your Alpha for NPM is 13.5.0-alpha.PLAY823globalpropoverflow1191

@app-milano app-milano bot temporarily deployed to pr2744 September 18, 2023 18:37 Inactive
@nidaqg nidaqg added the Ready for Release merged to master, ready for a versioned released label Sep 19, 2023
jasperfurniss
jasperfurniss previously approved these changes Sep 19, 2023
View reviewed changes
@nidaqg @jasperfurniss
Update playbook/app/pb_kits/playbook/pb_flex/_flex_item.tsx
958442e 
Co-authored-by: Jasper Furniss  <jasper.furniss@powerhrg.com>
@app-milano app-milano bot temporarily deployed to pr2744 September 19, 2023 13:43 Inactive
jasperfurniss
jasperfurniss previously approved these changes Sep 19, 2023
View reviewed changes
@nidaqg nidaqg added this pull request to the merge queue Sep 19, 2023
Merged via the queue into master with commit 0ba9976 Sep 19, 2023
@nidaqg nidaqg deleted the PLAY-823-global-prop-overflow branch September 19, 2023 17:31
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@nidaqg nidaqg

Labels
alpha enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nidaqg @jasperfurniss