Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-1011] Added Changelog Previews to Homepage #2765

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

jasperfurniss
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.
Adds cards back to the homepage. This time, we are parsing the markdown directly and giving it to the view. Before, we were waiting for html to load in the browser, and then parse that html, and then give that html to the view (which was causing loading issues).

Screenshots: Screenshots to visualize your addition/change

Screenshot 2023-09-27 at 9 44 17 AM

How to test? Steps to confirm the desired behavior:

  1. Go to homepage.
  2. See changelog cards.
  3. Click them to go to the right link.

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@jasperfurniss jasperfurniss requested a review from a team as a code owner September 27, 2023 13:48
@jasperfurniss jasperfurniss self-assigned this Sep 27, 2023
@jasperfurniss jasperfurniss added the milano 20 MAX - Deploy this PR to a review environment via Milano label Sep 27, 2023
@app-milano app-milano bot temporarily deployed to pr2765 September 27, 2023 15:13 Inactive
@jasperfurniss jasperfurniss added the Ready for Release merged to master, ready for a versioned released label Sep 28, 2023
@app-milano app-milano bot temporarily deployed to pr2765 September 28, 2023 16:51 Inactive
@nidaqg nidaqg added this pull request to the merge queue Sep 29, 2023
Merged via the queue into master with commit 7bdeea6 Sep 29, 2023
@nidaqg nidaqg deleted the markdown-fixes branch September 29, 2023 15:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants