[PLAY-1016] Reaction Button Emoji Fixes #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nidaqg
added
bug
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 13.8.0.pre.alpha.PLAY1016reactionbuttonemojibug1245 Your Alpha for NPM is 13.8.0-alpha.PLAY1016reactionbuttonemojibug1245 |
jasperfurniss
previously approved these changes
Oct 2, 2023
nidaqg
added
the
Ready for Release
jasperfurniss
approved these changes
Oct 4, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Number emojis were not being read as emojis by our reaction button kit. Fixed the isValidEmoji function to be more inclusive of all emojis
Screenshots: