[PLAY-845] Add swift to kits page #2778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 13.9.0.pre.alpha.play845addswiftkitspage1272 Your Alpha for NPM is 13.9.0-alpha.play845addswiftkitspage1272 |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 13.9.0.pre.alpha.play845addswiftkitspage1273 Your Alpha for NPM is 13.9.0-alpha.play845addswiftkitspage1273 |
markdoeswork
added
the
improvement
markdoeswork
added
the
milano
markdoeswork
changed the title
markdoeswork
added
milano
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 13.10.0.pre.alpha.play845addswiftkitspage1332 Your Alpha for NPM is 13.10.0-alpha.play845addswiftkitspage1332 |
jasoncypret
reviewed
Oct 27, 2023
playbook-website/app/components/playbook/pb_docs/kit_example.html.erb
Outdated
Show resolved
Hide resolved
markdoeswork
added
milano
jasperfurniss
approved these changes
Nov 10, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2023
**What does this PR do?** A clear and concise description with your runway ticket url. https://nitroqa.powerhrg.com/dev_docs/playbook Bug shipped in #2778
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 6, 2023
**What does this PR do?** A clear and concise description with your runway ticket url. [A recent PR broke sandpack experimental feature](#2778) This is an interim fix to check for missing variable def. A follow-up story should be created to fix the underlying missing `type` variable. cc: @nidaqg @jasperfurniss **Screenshots:** Screenshots to visualize your addition/change N/A #### Checklist: - [x] **LABELS** Add a label: `enhancement`, `bug`, `improvement`, `new kit`, `deprecated`, or `breaking`. See [Changelog & Labels](https://github.com/powerhome/playbook/wiki/Changelog-&-Labels) for details. - [x] **DEPLOY** I have added the `milano` label to show I'm ready for a review. - [ ] **TESTS** I have added test coverage to my code.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Inspired by #2756
We are adding a swift section to our docs website.
Swift docs do not have "example" files as our example docs run
erborjsxfiles and use that file extension to identify a file as an "example" file.mdfiles are for the description of the documentBecause all swift docs are
mdfiles I added a bunch of conditional logic that checks for_swiftin themdfile to consider it a sudo swift exampleHow to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.