Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-1027] 📄 Table kit [sortable] table header docs #2800

Merged
merged 13 commits into from
Nov 1, 2023
Merged

[PLAY-1027] 📄 Table kit [sortable] table header docs #2800

merged 13 commits into from
Nov 1, 2023

Conversation

Israel-Molestina
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.

  • Adds vertical cell lines
  • Fix spacing between header and icons
  • Highlight active column
  • Enable sorting functionality for doc example

Screenshots: Screenshots to visualize your addition/change
Screenshot 2023-10-19 at 4 27 42 PM

How to test? Steps to confirm the desired behavior:

  1. Go to https://playbook.powerapp.cloud/kits/table
  2. Scroll down to Table Header example
  3. Check that Headers can be clicked
  4. If header is clicked check that the column is highlighted and sorted correctly

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@Israel-Molestina Israel-Molestina added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Oct 19, 2023
@Israel-Molestina Israel-Molestina requested a review from a team as a code owner October 19, 2023 20:29
@Israel-Molestina Israel-Molestina self-assigned this Oct 19, 2023
@app-milano app-milano bot temporarily deployed to pr2800 October 19, 2023 20:48 Inactive
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1027-table-header-doc

@app-milano app-milano bot temporarily deployed to pr2800 October 20, 2023 15:42 Inactive
markdoeswork
markdoeswork previously approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@markdoeswork markdoeswork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@app-milano app-milano bot temporarily deployed to pr2800 October 20, 2023 20:27 Inactive
@app-milano app-milano bot temporarily deployed to pr2800 October 24, 2023 16:15 Inactive
@app-milano app-milano bot temporarily deployed to pr2800 October 26, 2023 17:01 Inactive
@app-milano app-milano bot temporarily deployed to pr2800 October 26, 2023 19:55 Inactive
@app-milano app-milano bot temporarily deployed to pr2800 October 26, 2023 20:16 Inactive
@app-milano app-milano bot temporarily deployed to pr2800 October 27, 2023 20:09 Inactive
@co1in-1ewis co1in-1ewis added the Ready for Release merged to master, ready for a versioned released label Oct 31, 2023
@jasperfurniss jasperfurniss removed the Ready for Release merged to master, ready for a versioned released label Nov 1, 2023
@jasperfurniss jasperfurniss added this pull request to the merge queue Nov 1, 2023
Merged via the queue into master with commit 301e31b Nov 1, 2023
@jasperfurniss jasperfurniss deleted the PLAY-1027-table-header-doc branch November 1, 2023 19:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasoncypret jasoncypret jasoncypret left review comments

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@markdoeswork markdoeswork markdoeswork left review comments

Assignees

@Israel-Molestina Israel-Molestina

Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Israel-Molestina @jasoncypret @jasperfurniss @markdoeswork @co1in-1ewis