Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PBIOS-161] Docs: Card #2808

Merged
merged 17 commits into from
Nov 3, 2023
Merged

[PBIOS-161] Docs: Card #2808

merged 17 commits into from
Nov 3, 2023

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Oct 23, 2023 •
edited
Loading

PBIOS-161

Screen.Recording.2023-10-24.at.11.03.29.AM.mp4

How to test? Steps to confirm the desired behavior:

  1. Pull down branch to your local env and navigate to the cards doc page

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia self-assigned this Oct 23, 2023
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbios-161-docs-card

@nickamantia nickamantia added swiftUI Any pr that has to do with iOS or Swift or the iOS Demo app improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Oct 23, 2023
@nickamantia nickamantia added the milano 20 MAX - Deploy this PR to a review environment via Milano label Oct 24, 2023
@app-milano app-milano bot temporarily deployed to pr2808 October 24, 2023 15:18 Inactive
@nickamantia nickamantia marked this pull request as ready for review October 24, 2023 15:32
@nickamantia nickamantia requested a review from a team as a code owner October 24, 2023 15:32
@app-milano app-milano bot temporarily deployed to pr2808 October 24, 2023 15:53 Inactive
@co1in-1ewis co1in-1ewis added the Ready for Release merged to master, ready for a versioned released label Oct 31, 2023
@jasperfurniss jasperfurniss added this pull request to the merge queue Nov 3, 2023
Merged via the queue into master with commit 87c0bd4 Nov 3, 2023
@jasperfurniss jasperfurniss deleted the pbios-161-docs-card branch November 3, 2023 13:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@isismsilva isismsilva isismsilva left review comments

@jasperfurniss jasperfurniss jasperfurniss approved these changes

Assignees

@nickamantia nickamantia

Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Ready for Release merged to master, ready for a versioned released swiftUI Any pr that has to do with iOS or Swift or the iOS Demo app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickamantia @jasperfurniss @isismsilva @co1in-1ewis