Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-1018] Update kit generator #2824

Merged
merged 33 commits into from
Nov 10, 2023
Merged

Conversation

markdoeswork
Copy link
Contributor

@markdoeswork markdoeswork commented Oct 31, 2023

What does this PR do? A clear and concise description with your runway ticket url

Runway: https://nitro.powerhrg.com/runway/backlog_items/PLAY-1018

Updates the generator so that you can specify swift as a kit type

Had to make some updates to the generator not just to add swift but how we store kits in the menu.yml has changed.
Also added alphabetization logic to the playbook.scss file

Screenshots: Screenshots to visualize your addition/change

Screenshot 2023-11-01 at 3 37 24 PM

How to test? Steps to confirm the desired behavior:

  1. git clone playbook
  2. cd playbook/playbook
  3. bin/rails g kit button (creates a button kit for rails, swift, react)
  4. You get a kit for each type
    --
  5. bin/rails g kit button --swift
  6. generates the kit for just swift
    --
  7. bin/rails g kit button --swift --rails
  8. generates the kit for swift and rails
  9. All two combinations work

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • [😈] TESTS I have added test coverage to my code.

@markdoeswork markdoeswork self-assigned this Oct 31, 2023
@markdoeswork markdoeswork added the milano 20 MAX - Deploy this PR to a review environment via Milano label Nov 1, 2023
@markdoeswork markdoeswork marked this pull request as ready for review November 8, 2023 14:36
@markdoeswork markdoeswork requested a review from a team as a code owner November 8, 2023 14:36
@markdoeswork markdoeswork added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Nov 9, 2023
jasperfurniss
jasperfurniss previously approved these changes Nov 10, 2023
@jasperfurniss jasperfurniss added this pull request to the merge queue Nov 10, 2023
Merged via the queue into master with commit b418737 Nov 10, 2023
@jasperfurniss jasperfurniss deleted the play/1018_update_kit_generator branch November 10, 2023 17:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants