-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[PLAY-1018] Update kit generator #2824
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laybook into play/845_add_swift_kits_page
markdoeswork
commented
Nov 1, 2023
markdoeswork
commented
Nov 1, 2023
jasperfurniss
previously approved these changes
Nov 10, 2023
jasperfurniss
approved these changes
Nov 10, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url
Runway: https://nitro.powerhrg.com/runway/backlog_items/PLAY-1018
Updates the generator so that you can specify swift as a kit type
Had to make some updates to the generator not just to add swift but how we store kits in the
menu.yml
has changed.Also added alphabetization logic to the
playbook.scss
fileScreenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
git clone playbook
cd playbook/playbook
bin/rails g kit button
(creates a button kit for rails, swift, react)--
bin/rails g kit button --swift
--
bin/rails g kit button --swift --rails
Checklist:
enhancement
,bug
,improvement
,new kit
,deprecated
, orbreaking
. See Changelog & Labels for details.milano
label to show I'm ready for a review.