[PLAY-1054] Use new sorting style #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdoeswork
added
breaking
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 13.10.0.pre.alpha.play1054tableheadersortconsolidation1416 Your Alpha for NPM is 13.10.0-alpha.play1054tableheadersortconsolidation1416 |
markdoeswork
added
enhancement
nidaqg
approved these changes
Nov 21, 2023
nidaqg
added
the
Ready for Release
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? A clear and concise description with your runway ticket url.
Runway: https://nitro.powerhrg.com/runway/backlog_items/PLAY-1054
Removes the explicit Acending/Decending options from the header dropdown
Checkout the page this is used on in Nitro:
https://pr35577.nitro-web.beta.hq.powerapp.cloud/project_surveys/surveys?q%5Bcompleted_date_beginning_of_day_gteq%5D=01%2F01%2F2022&q%5Bcompleted_date_end_of_day_lteq%5D=12%2F31%2F2022&q%5Bs%5D=percentage_2+desc
I originally thought this would produce a breaking change to Nitro, but I opted not to change the shape of the
sort_menuobject. Therefore no breaking change 🎉Screenshots: Screenshots to visualize your addition/change
From This:
To This:
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.