Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-1174] Fix confirmation toast mobile bug #3203

Merged
merged 15 commits into from
Mar 22, 2024

Conversation

markdoeswork
Copy link
Contributor

@markdoeswork markdoeswork commented Mar 5, 2024

What does this PR do? A clear and concise description with your runway ticket url.

Runway: https://nitro.powerhrg.com/runway/backlog_items/PLAY-1174
Alpha: https://pr38480.nitro-web.beta.gm.powerapp.cloud/user_requests/new?redirect_fallback=/sales/reps

Changed the css to consider not apply the same left/right logic as desktop for mobile

Showed to Kelly she suggested to force two lines. People shouldn't be using as much text as I am in my example

Screenshots: Screenshots to visualize your addition/change
ugly-error-on-mobile

screenshot-127 0 0 1_3000-2024 03 06-15_22_31

How to test? Steps to confirm the desired behavior:

  1. Go to https://pr3203.playbook.beta.gm.powerapp.cloud/kits/fixed_confirmation_toast/react
  2. Click on Multiline Example button
  3. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • [ 😈] TESTS I have added test coverage to my code.

@markdoeswork markdoeswork added the milano 20 MAX - Deploy this PR to a review environment via Milano label Mar 5, 2024
@markdoeswork markdoeswork self-assigned this Mar 5, 2024
Copy link

github-actions bot commented Mar 6, 2024

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.19.0.pre.alpha.play1174fixconfimationtoastmobilebug2305

Your Alpha for NPM is 13.19.0-alpha.play1174fixconfimationtoastmobilebug2305

@markdoeswork markdoeswork added alpha and removed alpha labels Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.19.0.pre.alpha.play1174fixconfimationtoastmobilebug2306

Your Alpha for NPM is 13.19.0-alpha.play1174fixconfimationtoastmobilebug2306

@markdoeswork markdoeswork added the bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) label Mar 6, 2024
@markdoeswork markdoeswork marked this pull request as ready for review March 6, 2024 20:28
@markdoeswork markdoeswork requested review from a team as code owners March 6, 2024 20:28
@markdoeswork markdoeswork added alpha and removed alpha labels Mar 12, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.19.0.pre.alpha.play1174fixconfimationtoastmobilebug2342

Your Alpha for NPM is 13.19.0-alpha.play1174fixconfimationtoastmobilebug2342

Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.19.0.pre.alpha.play1174fixconfimationtoastmobilebug2345

Your Alpha for NPM is 13.19.0-alpha.play1174fixconfimationtoastmobilebug2345

@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Mar 22, 2024
@thestephenmarshall thestephenmarshall added this pull request to the merge queue Mar 22, 2024
Merged via the queue into master with commit d3d9e1c Mar 22, 2024
5 checks passed
@thestephenmarshall thestephenmarshall deleted the play/1174_fix_confimation_toast_mobile_bug branch March 22, 2024 13:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants