Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PBNTR-204] add Turbo to Playbook POC #3211

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

nickamantia
Copy link
Contributor

@nickamantia nickamantia commented Mar 6, 2024

PBNTR-204

This PR adds Turbo in Playbook!!

Screenshots: Screenshots to visualize your addition/change

Screen.Recording.2024-03-05.at.02.43.40.PM.mp4

How to test? Steps to confirm the desired behavior:
Go to the Visual Guidelines page and test out the example!

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@nickamantia nickamantia added the milano 20 MAX - Deploy this PR to a review environment via Milano label Mar 6, 2024
@nickamantia nickamantia self-assigned this Mar 6, 2024
@nickamantia nickamantia marked this pull request as ready for review March 6, 2024 16:14
@nickamantia nickamantia requested review from a team as code owners March 6, 2024 16:14
@nickamantia nickamantia added the improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) label Mar 6, 2024
Copy link
Contributor

@thestephenmarshall thestephenmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR satisfies the PBNTR-204 story AC. No code nits, looks good to go! 🚢

nidaqg
nidaqg previously approved these changes Mar 7, 2024
@nickamantia nickamantia dismissed stale reviews from nidaqg and thestephenmarshall via 86962f3 March 7, 2024 20:56
@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Mar 8, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Mar 8, 2024
Merged via the queue into master with commit 19e6810 Mar 8, 2024
5 checks passed
@jasperfurniss jasperfurniss deleted the PBNTR-204-turbo-poc branch March 8, 2024 20:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants