Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable Remote Shell #3217

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Enable Remote Shell #3217

merged 1 commit into from
Mar 20, 2024

Conversation

thestephenmarshall
Copy link
Contributor

@thestephenmarshall thestephenmarshall commented Mar 7, 2024

What does this PR do?

This PR does not affect any development or production code! ⭐️

As a bonus for devs, it would be great to be able to log into PR review environments from our local machines in order to inspect the running file system and debug any issues.

Usage: make reviewShell pr=XXXX

The supporting bin stubs were lifted directly from nitro-web and only minor naming nitro-web -> playbook was updated within them.

PR Needs to Merge First

make reviewShell pr=3202
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "bin/cluster_for_review_stack": stat bin/cluster_for_review_stack: no such file or directory: unknown.
image-registry.powerapp.cloud/app/deployer:master-467d8015ffc91fc62c347367db792bb6de0eeea8-1439
./playbook-website/bin/deployer bash -lc "playbook-website/bin/remote_exec --time-to-live 3h --cluster  --namespace playbook-pr3202 bash --login"
image-registry.powerapp.cloud/app/deployer:master-467d8015ffc91fc62c347367db792bb6de0eeea8-1439
WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested
bash: playbook-website/bin/remote_exec: /usr/bin/env: bad interpreter: Permission denied
make: *** [reviewShell] Error 126

The above output just states that the specified bin stubs do no exist yet in master, so it is not possible to run them.

How to Test

  1. Merge this PR to master
  2. run the command above
  3. verify that you are logged into the remote shell

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@thestephenmarshall thestephenmarshall requested review from a team as code owners March 7, 2024 20:13
@thestephenmarshall thestephenmarshall self-assigned this Mar 7, 2024
@thestephenmarshall thestephenmarshall added enhancement New Features, Props, & Variants (USED IN CHANGELOG) and removed enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Mar 7, 2024
@thestephenmarshall thestephenmarshall added the milano 20 MAX - Deploy this PR to a review environment via Milano label Mar 7, 2024
@thestephenmarshall thestephenmarshall changed the title Test Out Remote Shell Enable Remote Shell Mar 7, 2024
@thestephenmarshall
Copy link
Contributor Author

@markdoeswork beat me to the punch last year with #2521

@jasperfurniss jasperfurniss added this pull request to the merge queue Mar 20, 2024
Merged via the queue into master with commit cbddf93 Mar 20, 2024
6 checks passed
@jasperfurniss jasperfurniss deleted the remote-shell branch March 20, 2024 14:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
milano 20 MAX - Deploy this PR to a review environment via Milano
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants