Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PBNTR-222] Fixing Advanced Table hover #3240

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

carloslimasd
Copy link
Contributor

@carloslimasd carloslimasd commented Mar 15, 2024

What does this PR do?
Fixing Advanced Table hover.

Screenshots:
image

How to test? Steps to confirm the desired behavior:

  1. Go to the Advanced Table docs
  2. Hover on any table

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@carloslimasd carloslimasd added bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano labels Mar 15, 2024
@carloslimasd carloslimasd self-assigned this Mar 15, 2024
@carloslimasd carloslimasd requested review from a team as code owners March 15, 2024 09:53
nidaqg
nidaqg previously approved these changes Mar 15, 2024
@nidaqg
Copy link
Contributor

nidaqg commented Mar 15, 2024

Looks good @carloslimasd ! Once Nick's dark modes PR merges, I would pull master and test to make sure this fix fixes the issue on dark mode as well before we merge it!

cc: @co1in-1ewis

@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Mar 20, 2024
@thestephenmarshall thestephenmarshall added this pull request to the merge queue Mar 22, 2024
Merged via the queue into master with commit 7b24cd1 Mar 22, 2024
5 checks passed
@thestephenmarshall thestephenmarshall deleted the PBNTR-222-advanced-table-hover branch March 22, 2024 13:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Fixes to issues discovered in Playbook (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants