Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[PLAY-1265] Add 'svg-inline--fa' class to our icons #3256

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

thestephenmarshall
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.

  • Fixes an issue where our own icons appear as vertically mis-aligned.

Screenshots: Screenshots to visualize your addition/change

Before

play-1265 circle icon button icon alignment

After

Screenshot 2024-03-20 at 9 41 09 AM

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@thestephenmarshall thestephenmarshall self-assigned this Mar 20, 2024
@thestephenmarshall thestephenmarshall added the milano 20 MAX - Deploy this PR to a review environment via Milano label Mar 20, 2024
@thestephenmarshall thestephenmarshall marked this pull request as ready for review March 20, 2024 14:12
@thestephenmarshall thestephenmarshall requested review from a team as code owners March 20, 2024 14:12
@co1in-1ewis co1in-1ewis added the Product Approved pending technical review, OK to merge to master label Mar 22, 2024
@thestephenmarshall thestephenmarshall added this pull request to the merge queue Mar 22, 2024
Merged via the queue into master with commit 6fbb2a8 Mar 22, 2024
6 checks passed
@thestephenmarshall thestephenmarshall deleted the PLAY-1265 branch March 22, 2024 13:44
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 13.21.0.pre.alpha.PLAY12652489

Your Alpha for NPM is 13.21.0-alpha.PLAY12652489

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
alpha milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants