Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[PLAY-1271][PLAY-1270] Enable Online Status & New Colors + Hide Date Range Picker Docs #3260

Merged
merged 2 commits into from
Mar 29, 2024
Merged

[PLAY-1271][PLAY-1270] Enable Online Status & New Colors + Hide Date Range Picker Docs #3260

merged 2 commits into from
Mar 29, 2024

Conversation

jasoncypret
Copy link
Member

@jasoncypret jasoncypret commented Mar 20, 2024 •
edited
Loading

What does this PR do? A clear and concise description with your runway ticket url.

  • Show Hidden Online Status Kit
  • Adds Additional Colors to Online Status
  • Hides Date Picker Range docs to avoid user confusion.

https://nitro.powerhrg.com/runway/backlog_items/PLAY-1270
https://nitro.powerhrg.com/runway/backlog_items/PLAY-1271

Screenshots: Screenshots to visualize your addition/change
Screenshot 2024-03-20 at 6 30 55 PM

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@jasoncypret jasoncypret requested review from a team as code owners March 20, 2024 23:29
@jasoncypret jasoncypret added milano 20 MAX - Deploy this PR to a review environment via Milano enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Mar 20, 2024
@jasoncypret jasoncypret changed the title Enable Online Status & New Colors + Hide Date Range Picker Docs [PLAY-1271][PLAY-1270] Enable Online Status & New Colors + Hide Date Range Picker Docs Mar 20, 2024
@nidaqg nidaqg added milano 20 MAX - Deploy this PR to a review environment via Milano and removed milano 20 MAX - Deploy this PR to a review environment via Milano labels Mar 21, 2024
@nidaqg
Copy link
Contributor

nidaqg commented Mar 21, 2024

Code looks good, but looks like it's failing the online_status kit's spec test. I think we just need to add the expanded colors to the spec test and it'll be good to go

@jasoncypret
Copy link
Member Author

Thanks @markdoeswork & @nidaqg

markdoeswork
markdoeswork approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@markdoeswork markdoeswork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@nidaqg nidaqg added the Product Approved pending technical review, OK to merge to master label Mar 28, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Mar 28, 2024
@jasperfurniss jasperfurniss added this pull request to the merge queue Mar 29, 2024
Merged via the queue into master with commit 2aec9a8 Mar 29, 2024
6 checks passed
@jasperfurniss jasperfurniss deleted the onlineStatus/HideDocs branch March 29, 2024 13:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@thestephenmarshall thestephenmarshall thestephenmarshall approved these changes

@jasperfurniss jasperfurniss jasperfurniss approved these changes

@markdoeswork markdoeswork markdoeswork approved these changes

Assignees

@jasoncypret jasoncypret

Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasoncypret @nidaqg @thestephenmarshall @jasperfurniss @markdoeswork